Skip to content

Update dependencies to packs shipped with 2.21.1 #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jcogs33
Copy link
Collaborator

@jcogs33 jcogs33 commented Apr 22, 2025

This PR:

  • Updates all the lock files to packages shipped with CodeQL 2.21.1
  • Updates the .codeqlversion to 2.21.1
  • Fixes compilation errors
  • Fixes test errors

This PR is based on #123, and will be merged after that PR is merged.

@GeekMasher
Copy link
Contributor

@jcogs33 Can you wait until #117 is merged update the .codeqlversion

@GeekMasher
Copy link
Contributor

@jorgectf The changes are merged now so you can directly set the CodeQL version in a single place. Let me know if you need any other help with this PR

@jcogs33 jcogs33 force-pushed the jcogs33/update-package-dependencies-2.21.0 branch from a560faf to 35abd73 Compare April 29, 2025 16:25
@jcogs33 jcogs33 changed the title Update dependencies to packs shipped with 2.21.0 Update dependencies to packs shipped with 2.21.1 Apr 29, 2025
@jcogs33 jcogs33 force-pushed the jcogs33/update-package-dependencies-2.21.0 branch from e19059b to 0d767fd Compare April 29, 2025 19:34
@jcogs33 jcogs33 mentioned this pull request Apr 29, 2025
@jcogs33 jcogs33 marked this pull request as ready for review April 29, 2025 21:22
@Copilot Copilot AI review requested due to automatic review settings April 29, 2025 21:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates all CodeQL dependency versions and adjusts configuration files to align with CodeQL 2.21.1. Key changes include:

  • Updating all lock files and the .codeqlversion file to 2.21.1.
  • Replacing outdated import paths (semmle.code.xml.MyBatisMapperXML) with the new semmle.code.java.frameworks.MyBatis in MyBatis-related queries.
  • Removing Spring Boot actuator related queries and configuration files that no longer compile.

Reviewed Changes

Copilot reviewed 62 out of 62 changed files in this pull request and generated no comments.

Show a summary per file
File Description
java/src/security/CWE-089/MyBatisMapperXmlSqlInjectionLib.qll Updated MyBatis import to the new framework path.
java/src/security/CWE-089/MyBatisMapperXmlSqlInjection.ql Updated MyBatis import to the new framework path.
java/src/security/CWE-089/MyBatisCommonLib.qll Removed the old MyBatis XML import in favor of the new frameworks import.
java/src/security/CWE-016/* (multiple files) Removed security rules and configuration for Spring Boot actuators.
(Various *.yml files in java, go, csharp, and cpp directories) Updated package versions in lock files.
.codeqlversion Updated version from 2.20.1 to 2.21.1.
Comments suppressed due to low confidence (3)

java/src/security/CWE-089/MyBatisMapperXmlSqlInjectionLib.qll:5

  • The import of 'semmle.code.xml.MyBatisMapperXML' has been replaced with 'semmle.code.java.frameworks.MyBatis'. Please verify that all dependent references are compatible with the new API.
import semmle.code.xml.MyBatisMapperXML

java/src/security/CWE-089/MyBatisMapperXmlSqlInjection.ql:16

  • The outdated import 'semmle.code.xml.MyBatisMapperXML' has been updated to 'semmle.code.java.frameworks.MyBatis'. Confirm that this change aligns with the expected behavior of the query.
import semmle.code.xml.MyBatisMapperXML

java/src/security/CWE-089/MyBatisCommonLib.qll:5

  • The removal of 'semmle.code.xml.MyBatisMapperXML' in favor of using 'semmle.code.java.frameworks.MyBatis' should be checked for compatibility across all MyBatis-related queries.
import semmle.code.xml.MyBatisMapperXML

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants